r/javascript • u/wasay-inc • 4d ago

AskJS [AskJS] :Recently got a PR merged into TanStack Query

I recently got a PR merged into TanStack Query's ESLint plugin to fix a false-positive issue in the no-unstable-deps rule

.

The existing tests missed a few JavaScript edge cases, so I fixed the underlying issue and added regression tests.

It's a good reminder that passing tests don't always mean every edge case is covered. Sometimes the real work is finding what the tests missed.

How do you usually spot gaps in test coverage when the existing suite is already passing?

0 Upvotes
  • permalink
  • reddit

38% Upvoted

7 comments sorted by

7

u/FairlyAloof 4d ago

love that you added regression tests too, nothing worse than fixing something only for it to break again six months later

1

u/wasay-inc 4d ago

Thanks man ! Exactly. Regression tests are easy to overlook, but they're what keep the same bug from creeping back in later.

2

u/Puzzleheaded-Comb646 4d ago

Congratulations on getting your PR merged, that is a huge milestone! Writing regression tests for those sneaky edge cases is such a valuable habit, and it is a great reminder for beginners that green checkmarks on a test suite just mean your current code passes the assumptions you already wrote down.

0

u/wasay-inc 4d ago

Thanks man ! Appreciate it

1

u/f3xjc 3d ago

You won't have perfect coverage and you won't prove the thing is bug free with unit test. What you can do is pin some behavior as intentional and make sure the thing do what you think it does on the example you can think of.

7

u/nxy7 4d ago

Slop